[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH] 3rd version of fix for -g switch missing from CFLAGS

From: Marc Singer <elf_at_buici.com>
Date: 2003-09-03 23:25:20 CEST

Construction of config.nice requires that the parameter list be
intact. Another reordering of the initial macros fixes this. I'd
prefer to save and restore $@, but I haven't found a way to do it.
Let me know if there is a better way.

========================================

I've looked deeper into the configure script and found that
--enable-debug is intended to enable inclusion of debug symbols by
*not* removing the -g switch from CFLAGS. But, it is foiled by the
APR macros which define CFLAGS and block the inclusion of the
'default' CFLAGS switches produced by AC_PROG_CC. This is fixed by by
moving the AC_PROG_CC macro to preceed the APR macros.

Some folks may have never experienced this problem. That could be due
to either a) a lack of APR in the build environment or b) definition
of CFLAGS in their environment.

========================================

Log:

Moved the AC_PROG_CC directive above the APR macros. Moved the
SVN_CONFIG_NICE invocation above AC_PROG_CC. Fixes the -g switch
inclusion when building with apr.

* configure.in: Moved AC_PROG_CC closer to top of file.

Index: configure.in
===================================================================
--- configure.in (revision 6952)
+++ configure.in (working copy)
@@ -53,6 +53,15 @@
 sinclude(build/ac-macros/berkeley-db.m4)
 sinclude(build/ac-macros/svn-apache.m4)
 sinclude(build/ac-macros/svn-macros.m4)
+
+dnl Generate config.nice early (before the args are munged)
+SVN_CONFIG_NICE(config.nice)
+
+dnl Look for a C compiler after svn-macros and before apr. Must be
+dnl after SVN_CONFIG_NICE so that the $@ list is intact. Must be
+dnl before apr so that CFLAGS hasn't already been changed.
+AC_PROG_CC
+
 sinclude(build/ac-macros/neon.m4)
 sinclude(build/ac-macros/find_apr.m4)
 sinclude(build/ac-macros/apr.m4)
@@ -66,9 +75,6 @@
 sinclude(ac-helpers/libtool.m4)
 
 
-dnl Generate config.nice early (before the args are munged)
-SVN_CONFIG_NICE(config.nice)
-
 dnl AC_CONFIG_HEADER causes `autoheader' to produce svn_private_config.h.in for us.
 dnl (We can add custom defines by creating ./acconfig.h if we wish.)
 AC_CONFIG_HEADER(svn_private_config.h)
@@ -175,9 +181,6 @@
 
 dnl Check for programs ---------------------
 
-dnl Look for a C compiler
-AC_PROG_CC
-
 dnl Look for a C pre-processor
 AC_PROG_CPP

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Sep 3 23:26:08 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.