Re: [PATCH] fix for --enable-debug configuration option

Marc Singer <elf@buici.com> writes:

Patches should be sent to the dev list (I've set Mail-Followup-To),
ideally they would include a log message as well. See the HACKING
file.

> I've looked deeper into the configure script and found that
> --enable-debug is intended to do the trick. What appears to be
> missing is the setting of the -g switch. This switch is supposed to
> be set automatically, but is being blocked by the presence of other
> options. The attached patch moves the check for the C compiler to the
> top of the configuration script which fixes the problem.

I don't understand your explanation of the problem, or your
explanation of the solution. What does "being blocked by the presence
of other options" mean?

If I run ./configure without your patch I get a Makefile that includes

CFLAGS = -g -O2 -pthread -DNEON_ZLIB -DNEON_SSL $(EXTRA_CFLAGS)

so I get -g without passing --enable-debug. (If I pass --disable-debug
the -g flag gets removed.)

With your patch I get I get

CFLAGS = -g -O2 -g -O2 -pthread -DNEON_ZLIB -DNEON_SSL $(EXTRA_CFLAGS)

which doesn't seem right.

I don't have apr, apr-util, db or neon in the Subversion build tree,
do you? Is that making the difference?

> Index: configure.in
> ===================================================================
> --- configure.in (revision 6949)
> +++ configure.in (working copy)
> @@ -49,6 +49,9 @@
> MKDIR="$INSTALL -d"
> AC_SUBST(MKDIR)
>
> +dnl Look for a C compiler early so that we get the -g switch
> +AC_PROG_CC
> +
> dnl Grab our own macros
> sinclude(build/ac-macros/berkeley-db.m4)
> sinclude(build/ac-macros/svn-apache.m4)
> @@ -175,9 +178,6 @@
>
> dnl Check for programs ---------------------
>
> -dnl Look for a C compiler
> -AC_PROG_CC
> -
> dnl Look for a C pre-processor
> AC_PROG_CPP

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org