[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Discussion: What should the test suite coding style look like?

From: <e.huelsmann_at_gmx.net>
Date: 2003-08-31 00:48:56 CEST

Hi.

Last week I submitted a patch (take 1) for the test suite. Next to changing
some code, I tried to make all tests look equal by changing some spacing.
cmpilato said he would like to have had the space-change in a separate patch. So
I am about to revert most of the space changes.

Before redoing them, I would like to ask you if it is necessary to agree
upon one coding style for the entire test suite (as far as that is possible).

The coding 'rules' would be:
- all defs defining a test would be preceeded by two empty lines
- all functions can contain empty lines, but never more than one between two
paragraphs of code
- the opening and closing parens delimiting the function argument list are
written against the first and last parameter in the list
- the opening paren of a function argument list is written directly after
the function name
- the sbox.build / wc_dir = sbox.... statements are always grouped together

Or maybe this is nonsense and that is exactly why mike wanted a different
patch (to be able to discard it really quickly)?

bye,

Erik.

-- 
COMPUTERBILD 15/03: Premium-e-mail-Dienste im Test
--------------------------------------------------
1. GMX TopMail - Platz 1 und Testsieger!
2. GMX ProMail - Platz 2 und Preis-Qualitätssieger!
3. Arcor - 4. web.de - 5. T-Online - 6. freenet.de - 7. daybyday - 8. e-Post
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Aug 31 00:49:45 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.