Re: Code cleanup: Harmonized tests

On Mon, Aug 25, 2003 at 11:38:04AM -0500, cmpilato@collab.net wrote:
> Michael Wood <mwood@its.uct.ac.za> writes:
>
> > On Sun, Aug 24, 2003 at 11:03:05AM +0200, Erik H??lsmann wrote:
> > [snip]
> > > Index: subversion/tests/clients/cmdline/diff_tests.py
> > > ===================================================================
> > > --- subversion/tests/clients/cmdline/diff_tests.py (revision 6841)
> > > +++ subversion/tests/clients/cmdline/diff_tests.py (working copy)
> > > @@ -75,7 +75,7 @@
> > > i += 1
> > >
> > > # no suitable diff found
> > > - return 1
> > > + raise 1
> >
> > I suspect you mean "raise svntest.Failure" here :)
>
> Actually, I think that this should have been left as "return 1". This
> is a helper function whose return value is used in both the "is" and
> "isn't" senses by its caller.

Ahhh. Serves me right for not checking the context :)

-- 
Michael Wood <mwood@its.uct.ac.za>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org