Re: Code cleanup: Harmonized tests

cmpilato@collab.net writes:
> Erik Hülsmann <e.huelsmann@gmx.net> writes:
>
> > Hi all,
> >
> >
> > Last week I submitted a little change to the svnversion test. Before
> > the test was found acceptable, I had to rewrite it so that it was
> > written as a 'new style' test: one which uses the Python exception
> > handling instead of the return 0 / return 1 structure.
>
> I'm reviewing this now.

I have a few comments about the patch:

1. Yay!

2. I'd like to see the whitespace changes in a separate patch, but
   that's not really A Big Deal.

3. I found a couple of places where you're doing this:

  stat_output, err_output = svntest.main.run_svn(None, 'stat', '-vN')
  if err_output:
    raise svntest.Failure

I'd like to see you use

run_and_verify_svn(message, expected_stdout, expected_stderr, *varargs):

in these cases. It integrates the checking for different outputs on
stderr and stdout. I've already converted a bunch of the tests to use
it, so there are plenty of examples.

Aside from that, yay!

> And I have to say, something about the phrase "bring into harmony
> with" just makes me feel good tonight.

:-)

-Fitz

--
Brian W. Fitzpatrick    <fitz_at_red-bean.com>   http://www.red-bean.com/fitz/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org