Re: [PATCH] svnadmin lsdblogs, fs.c, Windows

Martin Hauner wrote:
> ...
> + /* Windows: tell the bdb dll to use "our" heap to allocate filelist.
> + On Windows dlls have their own heap and we have to make sure
> + filelist is allocated from the same heap we free it from. */

Minor correction: "dlls have their own heap" should be "dlls sometimes have
their own heaps".

> + SVN_BDB_ERR (env->set_alloc (env,malloc,realloc,free));
> ...
> - free (filelist);
> + env->db_free (filelist);

Why add a call to set_alloc AND switch from free to db_free? Either change
should be sufficient by itself.

- Russ

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Aug 22 00:26:02 2003