[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 6786 - trunk/subversion/libsvn_fs

From: <cmpilato_at_collab.net>
Date: 2003-08-19 05:09:52 CEST

Greg Stein <gstein@lyra.org> writes:

> On Mon, Aug 18, 2003 at 05:47:08PM -0500, cmpilato@tigris.org wrote:
> > Author: cmpilato
> > Date: Mon Aug 18 17:47:06 2003
> > New Revision: 6786
> >
> > Modified:
> > trunk/subversion/libsvn_fs/tree.c
> > Log:
> > * subversion/libsvn_fs/tree.c
> > (svn_fs_root_t): Remove 'node_id_cache'. (This was the beginning of
> > another changeset, not meant to have been committed already.)
>
> Can you talk about what you're thinking here? Presuming it is some kind of
> cache, then what kinds of bounds will be on that cache size to prevent
> sucking up all of memory?

I can talk about how I reverted this portion of the cache change
because I decided that until I can come up with a clever way to bound
the growth, this patch is not getting committed. :-)

I don't know if "suck up all of memory" is a realistic concern -- my
estimates have it maybe growing to 30M for a 20,000-path checkout --
but still, until the algorithm is smart enough to bound growth and
intelligent roll things out of the cache, it's a non-starter (which
is, I'm sure, something you agree with).

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Aug 19 05:13:18 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.