RE: [PATCH] mod_authz_svn w/ SVNParentPath to include repo name in auth

> From: Jozef Hatala [mailto:jhatala@hotmail.com]
> Sent: Monday, August 18, 2003 5:30 AM

> Use the repository name in mod_authz_svn if configured with SVNParentPath,
> so that we can control access to repositories, which seems more useful
> to me. Normally nothing changes for those who use SNVPath.
>
> * subversion/mod_dav_svn/repos.c, subversion/include/mod_dav_svn.h,
> (dav_svn_split_uri): extra output parameter authz_path
>
> * subversion/mod_authz_svn/mod_authz_svn.c
> (check_access): renamed "repos_path" param to "authz_path"
> (auth_checker): use authz_path instead of repos_path
>
>
> I tested the change with release 0.27.0. It applies also to rev 6772.
> This diff is against rev 6772.
>
> Didn't I break anything?

Not so much, no. But I think there is a more elegant solution.
mod_dav_svn should grow another exported function which enables us
to ask if it is configured for SVNPath or SVNParentPath.

I'm thinking check_access should take an optional repository name.
That would be NULL when used with SVNPath and repos_name when used
with SVNParentPath. This could be used to build a new path to check:

[<repos_name>]<repos_path> /* Note that repos_path already has a '/' at the start */

Given that <repos_name> never starts with a '/' this is pretty
unambiguous.

Sander

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Aug 18 20:21:40 2003