On 17 Aug 2003 cmpilato@collab.net wrote:
> Ben Collins-Sussman <sussman@collab.net> writes:
>
> > Garrett Rooney <rooneg@electricjellyfish.net> writes:
> >
> > > Ben Collins-Sussman wrote:
> > >
> > > > Garrett, keep in mind that 'svn import' *already* detects binary files
> > > > and sets svn:mime-type to application/x-octet-stream while
> > > > committing. That's why it sometimes prints "A (bin) foo.doc".
> > >
> > > Yes, but setting svn:mime-type for binary files serves a more
> > > fundamental purpose (avoiding merges and eol translation on
> > > non-textual files), so it seems like a reasonable special case to me.
> >
> > I guess my take is -- hey, if we add Martin's auto-propset feature,
> > it would definitely be "turned off" by default.
> >
> > I'm thinking about all the users who have repeatedly complained that
> > they don't like having to remember to set svn:eol-style=native every
> > time they add a new source-code file. Some people have suggested
> > "recursive" directory props as a solution (really hard to implement),
> > other have suggested a server-side configuration solution (also
> > possible, but it's a very large change). Martin's patch seems pretty
> > simple, effective, and low-impact.
>
> I hear it. I totally dig the idea of the patch, and actually *want
> this* for myself in 'add' and 'import'. Yes, definitely, the default
> is off (meaning, what, that there's nothing but commented-out stuffs
> written to new .subversion areas?), but I soooooo want to import a
> website have my JPEGs be image/jpeg, my PNGs image/png, my HTML
> text/html, and so on, without having to write a custom script or do
> the work by hand.
>
Thank you all for your nice comments, and thank you Ben for the compliment :)
So here comes version 2 of my patch, but still not finished.
I've done some cleanup, added auto-props to import and added 2 enable
flags, one for svn add and one for svn import.
These flags are in ~/.subversion/config in the section miscellany, their
name is 'enable-auto-props-add' and 'enable-auto-props-imp', their value
can be 'true' or everything else.
Still missing is the testing of this feature and commandline switches for
the flags.
I thought i could add 2 commandline switches, --auto-props and
--no-auto-props, so enabling and disabling is both possible, and when they
are found on the cmdline the value of the config is overwritten with
svn_config_set().
This way i don't need to change any API or struct. Is that OK ?
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Aug 17 23:31:32 2003