Branko ÄŒibej wrote:
> rey4@tigris.org wrote:
>
>> Author: rey4
>> Date: Sat Aug 9 12:18:45 2003
>> New Revision: 6686
>>
>> Modified:
>> trunk/build/generator/gen_win.py
>> Log:
>> Visual Studio projects for perl bindings now link with the perl
>> library. The perl command used to figure out the library name came
>> from Branko Cibej <brane@xbc.nu> and Colin Watson
>> <cjwatson@flatline.org.uk>.
>>
>> * build/generator/gen_win.py
>> (WinGeneratorBase.__init__): now detects library name for
>> installed perl version
>>
>> (WinGeneratorBase.get_win_libs): now includes perl library
>>
>> + else:
>> + self.perl_lib = 'perl56.lib'
>> + sys.stderr.write('Could not detect perl version. Perl
>> bindings will\n' + ' be linked with %s\n' %
>> self.perl_lib)
>>
> If you can't detect the version of Perl, then most likely the user
> either doesn't have it installed, or it's not on the PATH. In any
> case, script generation should abort and the user should figure out
> what's wrong.
Since the only thing Perl is needed for is building the Perl bindings, it
doesn't make much sense to halt everything just because it isn't found. The
Perl detection I added is exactly like the Berkeley DB detection. If it
works, the detected value is used, otherwise a reasonable default is used,
and either way a status message gets printed with the results of
autodetection.
> Generating project files that you know won't work isn't
> right.
The resulting project file will work if the user later installs Perl 5.6.
And anyway, I think generating a project file that might not work is
preferable to not generating any project file at all. Let's say a user
builds Subversion and later installs Perl 5.8. If he then opens up visual
studio to build the Perl bindings, isn't it be better for him to see the
__SWIG_PERL__ project and get a sensible error message like 'Library
perl56.lib not found' when he tries to build it than for him to open the
workspace and not see the project listed at all? In the first case the user
at least has an error message to go on, in the second case he's likely to
wonder if its possible to build the Perl bindings at all in Visual Studio.
- Russ
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Aug 16 20:57:33 2003