Re: issue #1473

Hi good people.

I talked with sussman on the IRC regarding this issue and here's what we
discovered so far:

1. svn does indeed segfault when doing a repos->Working Copy copy of a
file where the svn:keywords is set.

2. The reason is that svn_wc__get_keywords (a function that is called by
the translate routine) tries to access the entry in the .svn/entries file,
and since the entry was not created yet it returns NULL.

3. svn_wc_add() is responsible for creating the entry, but it has not
called yet when the translation takes place.

4. The translation takes place in svn_wc_add_repos_file(), a recently
added function that is responsible to instantize all the file data based
on the input from the repository. It is called right before svn_wc_add().

The solution Ben and I came up to was to use a plain copy before the call
to svn_wc_add and then afterwards do the translation. This may mean
splitting the routine into two.

Does anybody have a better idea?

For more information, you can consult a log of the IRC session at channel
#svn, regarding this subject:

http://vipe.technion.ac.il/~shlomif/svn-issue-1473-irc-log.txt

(I am rindolf)

Regards,

        Shlomi Fish

----------------------------------------------------------------------
Shlomi Fish shlomif@vipe.technion.ac.il
Home Page: http://t2.technion.ac.il/~shlomif/

An apple a day will keep a doctor away. Two apples a day will keep two
doctors away.

        Falk Fish

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Aug 16 18:39:50 2003