Re: [PATCH] Put CPPFLAGS in SWIG_PY_COMPILE and friends

Eric Gillespie wrote:
> Does anyone have any objection to this change? CPPFLAGS often
> contains some necessary settings, and without it building the
> bindings can fail. I'll go ahead and commit if no one screams.
>
>
> * Makefile.in:
> Add $(CPPFLAGS) to SWIG_PY_COMPILE, SWIG_JAVA_COMPILE, and
> SWIG_PL_COMPILE.

I don't know anything about this change specifically, but it's always good for the log message to start with a summary of What you are changing and Why. For example, cutting and pasting from your Subject: and introduction,

[[[
Put CPPFLAGS in SWIG_PY_COMPILE and friends, because CPPFLAGS often
contains some necessary settings, and without it building the
bindings can fail.

* Makefile.in:
  Add $(CPPFLAGS) to SWIG_PY_COMPILE, SWIG_JAVA_COMPILE, and
  SWIG_PL_COMPILE.
]]]

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Aug 16 11:55:06 2003