[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn_pool_xxx vs apr_pool_xxx

From: Greg Stein <gstein_at_lyra.org>
Date: 2003-08-15 21:44:31 CEST

On Fri, Aug 15, 2003 at 08:32:25PM +0200, Sander Striker wrote:
>...
> > If we actually want to support anything sane happening on out-of-memory
> > errors, I think we have to check every call to apr_palloc(). In the
> > meantime, having the abort handler there is safer than just letting the
> > code get NULL pointers back and continue anyway.
>
> You snipped off the bottom part of my mail. We can add the abort handler
> in the command line client.

The libraries make a basic assumption that NULL will never be returned.
Until that assumption changes, I believe it is acceptable to abort().

If we remove the abort-on-failure, then it's gonna crash anyways, which is
effectively the same, so let's leave the abort in so it dies earlier rather
than later.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Aug 15 21:36:29 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.