[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: request for comments from developers about issues 1004 and 901

From: Philip Martin <philip_at_codematters.co.uk>
Date: 2003-08-14 13:06:49 CEST

"SteveKing" <steveking@gmx.ch> writes:

> ----- Original Message -----
> From: "Greg Hudson" <ghudson@MIT.EDU>
>>
>> Well, I continue to believe that we should use different callbacks for
>> different purposes, rather than using a giant union to shoehorn them all
>> into one callback. ("We're already shoehorning different things into
>> one callback" isn't a very compelling justification to keep doing it
>> that way.) I raised this issue a bit ago and got only a noncommital
>> response; I think we should resolve it.
>
> I agree. My first suggestion was a to use an additional callback function
> for that.

For the record, I don't object to an additional callback. The reason
I queried it is that it is a change to the current feedback "policy"
and I think such changes should be discussed.

>> So, you can start writing code for either approach, but don't be upset
>> if the design parameters change one way or the other mid-stream.
>
> I decided not to start coding on this. Karl mentioned that such a patch
> wouldn't have much chance of getting in so I would most likely just
> waste my time.

Looking through the archives I see you got burnt by svn:tarball. I
believe progress feedback is in a different category, I would be
surprised if anyone objected to the idea of progress feedback.

If you do decide to go ahead with a progress callback I suspect the
majority of the work will be arranging for the callback to be called,
rather than the details of the callback itself. I see there is a neon
progress callback, were you planning to use that? What about ra_svn?
It would be great if both network layers provided progress feedback,
although I guess an ra_dav only version would be a good start. Are
you considering moving the existing commit feedback for text-deltas
from the notify callback to the progress callback?

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Aug 14 13:08:23 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.