On Mon, 11 Aug 2003 kfogel@collab.net wrote:
> Shlomi Fish <shlomif@vipe.stud.technion.ac.il> writes:
> > OK, I removed the patches that were already applied from my patches
> > directory, and now it contains only unapplied patches (4 of them so far).
> >
> > The URL is as always:
> >
> > http://t2.technion.ac.il/~shlomif/svn-patches/
>
> Thanks, I took a look. A couple of quick suggestions:
>
> 1) Put log message and patch in the same file, so there's exactly
> one file per patch.
>
I'd rather not. It makes it more difficult to apply the patch.
> 2) When the patch is for an issue, make a note in the issue
> giving the URL for the (single) patch file.
>
OK.
> Regarding the specific patches:
>
> Are these for an open issue?:
>
> add-config-dir-rev2...> 10-Aug-2003 11:40 2k
> add-config-dir-rev2...> 10-Aug-2003 11:40 36k
> add-config-dir.log.txt 10-Aug-2003 11:40 1k
> add-config-dir.patch..> 10-Aug-2003 11:40 23k
>
add-config-dir.patch.txt and add-config-dir.log.txt are no longer valid
and rather broken. Use add-config-dir-rev2. What this patch does is add
a --config-dir option to the command line clients (and underlying
libraries) to specify an alternative directory where one can find the
configuration files. It helps for Issue #1385:
http://subversion.tigris.org/issues/show_bug.cgi?id=1385
and may be usable in other cases.
> This one is for a Post-1.0 issue (the patch looks good to me, by the
> way; I'd like for Sander Striker, Justin Erenkrantz, or some other
> APR/Apache/HTTP-knowledgeable person to glance at it, but I think it
> can & should be applied):
>
> issue-1209-fix.log.txt 10-Aug-2003 11:40 1k
> issue-1209-fix.patch..> 10-Aug-2003 11:40 1k
>
> This issue is closed, MBK has applied your patch:
>
> issue-1266-fix.log.txt 10-Aug-2003 11:40 1k
> issue-1266-fix.patch..> 10-Aug-2003 11:40 1k
>
So I see. OK, I'll remove them from the collection.
> This issue is assigned to me, so I'll review your patch right away
> (and I'll link to your patch in the issue, you don't need to do it):
>
> issue-1313-fix.log.txt 10-Aug-2003 11:40 1k
> issue-1313-fix.patch..> 10-Aug-2003 11:40 3k
>
OK.
> Thanks,
> -Karl
>
----------------------------------------------------------------------
Shlomi Fish shlomif@vipe.technion.ac.il
Home Page: http://t2.technion.ac.il/~shlomif/
An apple a day will keep a doctor away. Two apples a day will keep two
doctors away.
Falk Fish
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Aug 11 17:41:18 2003