Re: [PATCH] Re: should .subversion/config hint to ignore .DS_Store?

cmpilato@collab.net writes:

> Jack Repenning <jrepenning@collab.net> writes:
>
> > The config file installed into ~/.subversion (or wherever your
> > favorite platform puts these things) includes a commented-out section,
> > [miscellany], which includes a commented-out global-ignores setting.
> > While I realize this is all commented out, so very little will go
> > horribly wrong if it's slightly incomplete, still it's useful
> > documentation/hintage.
> >
> > I think maybe it should include ".DS_Store" in the list of things to
> > global-ignore. This is a MacOS X thing; MacOS creates them freely in
> > the HFS+ volumes. I think I used to know what they are, but I forget
> > ;-) Google will show you several discussions about getting them into
> > .cvsignore. Google wil also show you several .DS_Store files that
> > have already been checked into Subversion repositories, e.g. at
> > svn.sabi.net/.../ICeCoffEEE/. I very much suspect this was an error
> > ;-)
>
> Here's a patch if folks want to review/commit it. I can't test it
> (not a Mac user), and it ain't my itch.

And here's a refined patch based on the latest codebase.

--
* subversion/include/svn_config.h
  (SVN_CONFIG_DEFAULT_GLOBAL_IGNORES): Add ".DS_Store" to the list.
Index: subversion/include/svn_config.h
===================================================================
--- subversion/include/svn_config.h	(revision 6685)
+++ subversion/include/svn_config.h	(working copy)
@@ -88,7 +88,7 @@
 /*** Configuration Default Values ***/
 
 #define SVN_CONFIG_DEFAULT_GLOBAL_IGNORES \
-   "*.o *.lo *.la #*# .*.rej *.rej .*~ *~ .#*"
+   "*.o *.lo *.la #*# .*.rej *.rej .*~ *~ .#* .DS_Store"
 
 
 /** Read configuration information from the standard sources and merge
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org