Re: [PATCH] dynamically link swig runtime on windows (Can I commit this?)

Russell Yanofsky wrote:

>Branko Čibej wrote:
>
>
>>I _still_ don't understand why you don't generate these sources in
>>gen_win.py when the .dsp/.vcproj stuff is generated, and not from the
>>project files themselves.
>>
>>
>
>I just want to keep the ugliness of building the swig runtime out of
>gen-make. In general, gen-make should be limited to generating makefiles and
>project files. If it becomes an all purpose build script, it's going to turn
>into spaghetti and be more diffcult to maintain.
>
There's no reason why gen-make shouldn't do that, if it's the best
place. Anyway, the code generation would be don in gen_win.py, where we
already do a bit of that -- see the bit in gen_win.__init__ where we
generate getdate.c. Since the SWIG runtime sources never change (well,
unless you install a new version of SWIG), there's no need to generate
them during the build. I think it's much cleaner to do so before.

-- 
Brane Čibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org