Re: [PATCH] Fix SIGSEGV in svn_path_is_uri_safe

kfogel@collab.net wrote:

>Branko Čibej <brane@xbc.nu> writes:
>
>
>>I seem to remember us having a policy that it's the caller's
>>responsibility to pass valid parameters to a function -- in this case,
>>the caller shouldn't call path_is_uri_safe at all if the parameter is
>>NULL. Has this policy changed?
>>
>>
>
>Which parameter do you mean?
>
>The bug here was not that the parameter to svn_path_is_uri_safe() was
>NULL, but that we were failing to check the result of a strchr() call
>for NULL. In other words, just an implementation braino, no deeper
>implications as far as I can tell...
>
>
Yikes. Shows what happens if you "review" stuff in the middle of the
night. Sorry.

-- 
Brane Čibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org