Re: [PATCH] Add diagnostic output to svnversion_tests.py

Erik Hülsmann <e.huelsmann@gmx.net> writes:

> Actually, my first design was like that, but then I looked at the tests
> which use the run_and_verify_* api for testing subversion calls and
> I discovered that the error is thrown by the calling test, not by
> within the api.

Erik, our test suite in halfway through a conversion from returning
non-zero to throwing exceptions. Is it the case that run_and_verify_*
doesn't raise exceptions, or is it that the calling functions you
examined haven't yet been converted to the new exception-full format?
Knowing that we need to eventually get around to removing all those
"return 1"s from the test suite, I'm hesitant to add still more of
them if that's not necessary.

Sorry our test suite isn't exactly in a state of being a useful
example of its own desired design.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Aug 5 18:57:16 2003