[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: Recommending attached instead of inline patches?

From: Sander Striker <striker_at_apache.org>
Date: 2003-08-05 00:04:27 CEST

> From: Justin Erenkrantz [mailto:justin@erenkrantz.com]
> Sent: Monday, August 04, 2003 11:19 PM

> --On Monday, August 04, 2003 10:50:05 -0500 kfogel@collab.net wrote:
>> I'm beginning to think we should just change that policy. It's
>> slightly more convenient to review an inline patch -- but not by much.
>> And sometimes people's mailers munge them, and mail archivers don't
>> behave as well, etc. The costs may outweigh the benefit...

In this case, the benefit is almost close to nil.
 
> -0. I don't trust mailers to get this right, and we don't need more
> obstacles to reviewing patches that are sent in. I don't give a fig about
> archivers if it means that it's impossible to review the attachments for
> people reading the list currently.

Not to mention that there will be less review, simply because you don't
see the patch straight away.
 
> IIRC, at one point Sander tried attaching patches (if not here, then to
> dev@httpd), but LookOut! always munged them so that no one else could ever
> view them.

Nope, the other way around. I was having trouble sending inline patches
since you have to set your max line width globally (and it only goes to
132). Once I set that inline patches were doable.

> I think it was eventually resolved that it was impossible for
> Outlook to do this right with attachments at all. Considering how many
> people use Outlook, asking for attachments by default is going to be a mess
> that I don't want a part of. -- justin

It's going to be more hassle to view them, which is a shame. With broken
mail clients, like the one I use, viewing something with an extension other
than .patch or .txt (the latter giving trouble with unix line endings, since
it defaults to notepad), is an utter pain. You have to save the patch to
disk first, before you can open it in that case.

So, a strong -0 on going to attached patches.

Sander

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Aug 5 00:05:14 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.