[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] dynamically link swig runtime on windows (Can I commit this?)

From: Brandon Ehle <azverkan_at_yahoo.com>
Date: 2003-07-31 18:16:26 CEST

Russell Yanofsky wrote:

>I was recently given commit access for the swig bindings, but I'd like to
>check in some changes to the build generator. A patch is attached. Is it ok
>for me to check this in?
>Log Message:
>Changed Visual Studio builds of SWIG bindings to dynamically link
>with the SWIG runtime instead of statically linking with it.
>(Makefile builds already do this). This is needed because the
>SWIG runtime functions read and write global data. When static
>linking is used each module gets its own incomplete copy of the
>global data, now data is shared and accessible to all modules.
>* build/win32/gen_swig_runtime.bat:
> new batch script which generates swig runtime code for
> various languages
Excuse my ignorance, but what does this batch file actually do? Like
cmpilato said, its Greek to me. Couldn't we do this in a much cleaner
and OS independent way?

I notice the section of code at the top does the following:

REM Enable Command Extensions, needed for FOR command below
  ECHO Error: Unable to enable command extensions >&2
  EXIT /B 1

Before we depend on something like this, shouldn't we implement a
fallback case for when those extensions are not available?

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Jul 31 18:17:30 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.