Re: [PATCH] Issue #1074: Need a svnadmin command to verify that the repository is not corrupted (Take 2)

John Szakmeister <john@szakmeister.net> writes:

> Just wanted to see if anyone has taken a look at this new patch. If so, and
> there are problems, please let me know! :-)

I've got it marked for review in my Inbox. Sorry I didn't reply with
as much. As far as problems with the patch, I haven't yet looked at
it. But a theoretical concern struck me. Looping over all the
representations in the 'representations' table means we will be
sanity-checking not just the immutable (committed) data, but also the
data in progress under not-yet-committed transactions.

Now, in theory this is not a problem, because the representations
should always reflect the true state of what's in the database (and if
they don't, we probably want to know about it). Further,
administrators can always choose to purge their uncommitted (and for
whatever reason, un-autopurged) transactions before running the verify
command.

So, perhaps I just talked myself out of worrying about this
implementation. :-)

I'll review your patch now. (Though, since I'm on a commuter train,
you won't find this out until I get a chance to send this mail).

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Jul 31 16:37:43 2003