[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: Issue 533 - locking

From: D.J. Heap <djheap_at_dhiprovo.com>
Date: 2003-07-28 18:51:08 CEST

I actually attempted the pre-commit hook approach first, but hooks
aren't completely functional on Windows (stdin/out redirection appears
to be broken -- if a hook returns failure you get a boatload of Invalid
Handle messages back in the client and not the hook's output -- I think
Brane referred to it a little while ago).

Also, svnlook only seems to show changed directories in the transaction,
not each file -- is that correct? So I need to write a little helper
app of some kind to look through the transaction's changed nodes and
then check for a lock/reserve property, right?

I'll look further into the hook problem -- you and the other various
reply's have convinced me that is a better approach until the heavier
duty shared/exclusive locking is implemented.



-----Original Message-----
From: sussman@collab.net [mailto:sussman@collab.net]
Sent: Monday, July 28, 2003 10:10 AM
To: D.J. Heap
Cc: Subversion
Subject: Re: Issue 533 - locking

"D.J. Heap" <dj@shadyvale.net> writes:

> Here's a little patch to implement the core of kfogel's remarks in
> 533 on locking. Basically it just stops the commit if a node has
> the svn:locked property set to a username other than the committer's.

As jerenkrantz already pointed out: last November, a great number of
svn developers met at ApacheCon and came up with a very complex,
post-1.0 locking system, documented in notes/.

Regarding this patch, I have one question: why can't this be done
with a pre-commit hook script? Your company can invent their own
property ("mycompany-lock:author"), attach it to files, and your
custom pre-commit hook can look for the property on changed-files in
the transaction. If present, disallow the commit.

This email and any files transmitted with it are confidential
and intended solely for the use of the individual or entity to
whom they are addressed. If you have received this email
in error please notify the system manager.

This footnote also confirms that this email message has been
swept by MIMEsweeper for the presence of computer viruses.


To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Jul 28 18:51:59 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.