[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] python bindings bugfix for svn_repos_get_logs (resend, issue 1387)

From: Russell Yanofsky <rey4_at_columbia.edu>
Date: 2003-07-27 22:13:21 CEST

cmpilato@collab.net wrote:
> "Russell Yanofsky" <rey4@columbia.edu> writes:
>> The immutable marker just prevents users from assigning their own
>> values to that member so there can't be any leaks.
> Sounds great -- thanks for explaining. Would you mind (if you have
> the time) giving the rest of our bindings code a once-over to see if
> we need such a restriction placed on other class members?

A patch is attached that places the same restriction on other const char *
members. I didn't look over the bindings code, just dealt with swig warning

Log Message:

Prevent users of swig bindings from assigning to const char * struct members so
there won't be any memory leaks.

* subversion/bindings/swig/core.i: made struct members which cause
"Warning(451): Setting const
   char * member may leak memory" immutable.

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

  • application/octet-stream attachment: leak.diff
Received on Sun Jul 27 22:10:44 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.