[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index


From: D.J. Heap <dj_at_shadyvale.net>
Date: 2003-07-27 15:26:14 CEST

People having trouble with svn+ssh look like they could be helped with a
bit more error checking in libsvn_ra_svn\client.c where it creates the
tunnel agent process around line 387:

   if (tunnel)
       SVN_ERR(find_tunnel_agent(tunnel, hostname, &args, config, pool));
       apr_procattr_create(&attr, pool);
       apr_procattr_io_set(attr, 1, 1, 0);
       apr_procattr_cmdtype_set(attr, APR_PROGRAM_PATH);
       apr_procattr_child_errfn_set(attr, handle_child_process_error);
       proc = apr_palloc(pool, sizeof(*proc));
       apr_proc_create(proc, *args, args, NULL, attr, pool);
       conn = svn_ra_svn_create_conn(NULL, proc->out, proc->in, pool);
       conn->proc = proc;

Windows, at least, seems to hang somewhere afterwards if the
apr_proc_create fails. Some error checking on that call might be
needed...I don't have time right now, but I can look at it later this
week if no one else has.


To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Jul 27 15:27:19 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.