[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] cvs2svn on windows (resend)

From: Francois Beausoleil <fbos_at_users.sourceforge.net>
Date: 2003-07-26 19:13:44 CEST

On Fri, 25 Jul 2003 19:21:38 -0400, "Russell Yanofsky"
<rey4@columbia.edu> said:
> Francois Beausoleil wrote:
> > Ok, I applied Russel's patch. I get an error:
> > ...
> > File "E:\svn-trunk\tools\cvs2svn\cvs2svn.py", line 325, in
> > relative_name
> > assert fname[:l] == cvsroot and fname[l] == os.sep
> > NameError: global name 'l' is not defined
>
> I don't see how you can get this error unless there is something wrong
> with your
> patch program or you applied the patch to the wrong version of
> cvs2svn.py. The
> relevant section of the patch reads:

Well, my patch program did a booboo... It was my fingers and brain that
did it ;) That's why. I did not see the "l" var being defined.

Sorry for the false alarm...

>
> @@ -323,11 +323,8 @@
>
> def relative_name(cvsroot, fname):
> l = len(cvsroot)
> - if fname[:l] == cvsroot:
> - if fname[l] == '/':
> - return fname[l+1:]
> - return fname[l:]
> - return l
> + assert fname[:l] == cvsroot and fname[l] == os.sep
> + return string.replace(fname[l+1:], os.sep, '/')
>
> So the variable l will always be defined.
>
> - Russ
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org
>
>
Developer of Java Gui Builder
http://jgb.sourceforge.net/

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Jul 26 19:14:40 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.