Re: [PATCH] bash_completion: improvement, fixes and tests [was: Re: subversion and programmable completion]

Julian Foad <julianfoad@btopenworld.com> writes:

> I can understand you wanting completion after "svn --help " but that
> wasn't what those tests were looking at. They were looking at
> completing the first argument. My one-line patch allows "svn
> --"<TAB> to produce "--help" and "--version" as completions, rather
> than just filling in "--version" immediately. It completes "svn
> --he"<TAB> to "svn --help" immediately. It does not list svn
> subcommands after "svn --help "<TAB>; it offers "--help" and "-h"
> which is completely wrong and useless, but exactly the same as your
> version in that situation.

My argument is that "svn --help " breaks further completion so I don't
want to completion to suggest it. The "--help" option is not special
here, all options break completion if they occur first, so "svn -v "
breaks further completion even though "svn -v st" is a valid command.

At present completion on "svn " suggests commands that don't break
further completion. It seems sensible to me that completion should
encourage the use of sequences that allow further completion. For
completion to suggest a commmand that breaks further completion is not
very user-friendly.

Completion suggests "svn help", "svn h" and "svn ?", all of which
allow further completion, why should it suggest "svn --help" which
breaks further completion?

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org