Re: [PATCH] bash_completion: improvement, fixes and tests [was: Re: subversion and programmable completion]

Julian Foad <julianfoad@btopenworld.com> writes:

> I see that you followed up in revision 6562 with some changes so
> that no tests would fail. In doing that, did you intentionally
> remove the tests for completing "svn --he" etc.?

It was intentional. There are lots of valid svn commands for which
bash_completion will not work, e.g. 'svn --verbose status'. I didn't
see why 'svn --help' needed to be supported, particularly as the
completion for 'svn' no longer suggests '--help'.

> I liked that particular completion, and it was valid.

If you can make it work I will reinstate it. At the moment
bash_completion doesn't suggest every possible command, but I think
all the suggestions it offers are valid. I'd like to keep it that way.

> I spent some of today looking at fixing the handling of help options
> in "svn" itself. For instance, "svn add --version" gives the help
> for "svn add" which I do not think was intended.

That's probably an error, although not a very serious one. Ideally it
should complain that '--version' is not a valid option for 'add', and
then print the help.

> But I don't know exactly what the command-line syntax should be -
> e.g. whether "svn add cat --help" should be interpreted as an "add"
> command or a "help" command.

That appears to have the same behaviour as 'svn help add cat', and
while that is possibly a little surprising, I think it's acceptable.

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org