Re: [neon] [PATCH] GSSAPI support for neon

>> Thanks for your patch, here is our product of the day.
>>
>> The base64 modification is required to work, so please apply it too!
>
> I forgot to mention - this was fixed already in neon 0.24.0. (the fix
> was simply to make the input buffer "unsigned")

Hmmm, it's a bit simpler...

> The new log_gss_error function is a lot of effort just for debugging
> output. If you really want this can you indent the code properly,
> surround it with #ifdef NE_DEBUGGING, and try and simplify it? Could it
> just progressively print the result of each call to gss_display_status
> rather than trying to buffer it all up?

You're right, but now I haven't got time to write a better one, I will
(hopefully) do on a nice day, drop it for now, but please change
    if (GSS_ERROR(major_status)) {
        return -1;
    }
with
    if (GSS_ERROR(major_status)) {
        NE_DEBUG(NE_DBG_HTTPAUTH, "GSSAPI Failed.\n");
        return -1;
    }
then.

> Attached a new combined attempt, with log_gss_error removed for the
> moment. Can you test this as well? I'll commit this if you confirm it
> works.

It works.

The another bug in the feature request can be workarounded on the
server side with an ugly apache2 config. If anybody wants it, mail me.

Gergely

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Jul 23 23:16:06 2003