Re: [PATCH] mod_authz_svn crasher and logic error

> > hostname and scheme happen to be two that we don't necessarily get.
> Urgh. Ok. I'll investigate this on the httpd end. IMO, these should
> be filled out properly.

Cool.

> > * mod_authz_svn.c - fix a segfault and a logic error in the MOVE/COPY
> > portion of the test (r->parsed_uri was not filled out
>
> I'll remove the check for now. That is effectively what your patch does
> aswell.

I had made it conditional, based on the assumption that it may have
worked for some folks.

> > and order of arguments to strncmp is important)
>
> Well, this is a new one for me. I can't really tell that from man strncmp.
> Give me clue on this one please.

       The strcmp() and strncmp() functions return an integer less
       than, equal to, or greater than zero if s1 (or the first n
       bytes thereof) is found, respectively, to be less than, to
       match, or be greater than s2.

That was my interpretation of the above through the odd fog I was
living in yesterday. But I agree that it's silly.

But I do remember seeing the strncmp fail if the arguments were in the
original order.

-R

-R

Footnotes:
[1] Code would work, and then not work immediately after. My
thinkpad ate another hard drive. etc..

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Jul 23 16:25:10 2003