[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 6536 - trunk/tools/cvs2svn

From: <cmpilato_at_collab.net>
Date: 2003-07-23 03:15:57 CEST

Greg Stein <gstein@lyra.org> writes:

> On Tue, Jul 22, 2003 at 03:19:14PM -0500, kfogel@tigris.org wrote:
> > Author: kfogel
> > Date: Tue Jul 22 15:19:13 2003
> > New Revision: 6536
> >
> > Modified:
> > trunk/tools/cvs2svn/cvs2svn.py
> > Log:
> > Fix issue #1416: failing to parse binary RCS files on Windows.
> >
> > * tools/cvs2svn/cvs2svn.py
> > (visit_file, RevInfoParser.parse_cvs_file): Open in binary mode.
> > (Dumper.add_or_change_path): Don't pass a buffer size to os.popen;
> > there's no need to optimize for the svn filesystem anymore, and on
> > Windows os.popen doesn't take that argument.
>
> Wasn't this a patch from a contributor? e.g. recognition in the log msg?

If there was a patch, we didn't use it.

Hey, wait a second! This solution was actually suggested to Karl by
me -- I even typed the changes on the Windows 98 box -- and *I* didn't
even get credit! Foul! Foul! :-)

Love, a not-really-caring C-Mike

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Jul 23 03:17:00 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.