Re: [PATCH] mod_authz_svn crasher and logic error

Robert Spier <rspier@pobox.com> writes:

> Index: mod_authz_svn.c
> ===================================================================
> --- mod_authz_svn.c (revision 6536)
> +++ mod_authz_svn.c (working copy)
> @@ -307,8 +307,8 @@
>
> apr_uri_parse(r->pool, dest_uri, &parsed_dest_uri);
>
> - if (strcmp(parsed_dest_uri.hostname, r->parsed_uri.hostname)
> - || strcmp(parsed_dest_uri.scheme, r->parsed_uri.scheme)) {
> + if (strcmp(parsed_dest_uri.hostname, parsed_dest_uri.hostname)
> + || strcmp(parsed_dest_uri.scheme, parsed_dest_uri.scheme)) {

Huh? What is this meant to do? strcmp(foo, foo) is a strange test!

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org