Re: [PATCH] Fix for Issue 1267

On Fri, 18 Jul 2003, Philip Martin wrote:

> Shlomi Fish <shlomif@vipe.stud.technion.ac.il> writes:
>
> > Hmmm... there was an indentation misbehaviour in the previous patch, so
> > here's a corrected one. Enjoy!
>
> The patch is also reversed, something that would not happen if you
> used 'svn diff'.
>

I'll remeber that, next time.

> It's eaiser to keep track of things if you send the log message every
> time you send the patch
>

OK.

> > --- subversion/subversion/libsvn_ra_dav/session.c 2003-07-18 02:32:57.000000000 +0300
> > +++ subversion/subversion/libsvn_ra_dav/session.c.orig 2003-07-18 02:05:59.000000000 +0300
> > @@ -108,12 +108,6 @@
> > return 0;
> > }
> >
> > -typedef struct
> > -{
> > - svn_ra_session_t * ras;
> > - svn_ra_ne_session_baton_t * ne_sess_baton;
>
> Minor whitespace nit, most of the Subversion code uses
>
> svn_ra_session_t *ras;
> svn_ra_ne_session_baton_t *ne_sess_baton;
>

That's easy to fix.

> > bt = apr_palloc(pool, sizeof(*bt));
>
> I don't know much about the neon-Subversion interface, but this looks
> a little odd to me. Why are two separate batons allocated (ssl_baton
> and bt) one of which contains a pointer to the other? Should they be
> combined?
>

Not really. ssl_baton is for the server_ssl_callback function and itself
contains two other batons (the ras and the bt). bt is the neon session
baton, and it does not contain ras. We need them all.

Regards,

        Shlomi Fish

----------------------------------------------------------------------
Shlomi Fish shlomif@vipe.technion.ac.il
Home Page: http://t2.technion.ac.il/~shlomif/

An apple a day will keep a doctor away. Two apples a day will keep two
doctors away.

        Falk Fish

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Jul 18 18:43:28 2003