[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 6497 - in trunk/subversion: clients/cmdline include libsvn_client

From: <cmpilato_at_collab.net>
Date: 2003-07-17 16:38:01 CEST

kraai@tigris.org writes:

> Author: kraai
> Date: Thu Jul 17 04:04:48 2003
> New Revision: 6497
>
> Modified:
> trunk/subversion/clients/cmdline/main.c
> trunk/subversion/clients/cmdline/propdel-cmd.c
> trunk/subversion/clients/cmdline/propedit-cmd.c
> trunk/subversion/clients/cmdline/propset-cmd.c
> trunk/subversion/include/svn_client.h
> trunk/subversion/include/svn_error_codes.h
> trunk/subversion/libsvn_client/prop_commands.c
> Log:
> Fix issue #1401: Check for newlines in svn:author revision property.

-1 on this change. We own the svn: properties, and have the right to
flatly deny multiline values for svn:author. So let's do so.

Actually, I'd like something a tad more complex:

   - if the value is "author", it's good.
   - if the value is "author\n", strip the \n and store it.
   - if the value is "author\nstuff", error.

No force options, period.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Jul 17 16:38:43 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.