[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] "svn up" should not tree lock the anchor unless it's wc root

From: Chia-liang Kao <clkao_at_clkao.org>
Date: 2003-07-13 13:46:35 CEST

On Sun, Jul 13, 2003 at 11:13:28AM +0100, Philip Martin wrote:
> > - SVN_ERR (svn_wc_adm_open (&adm_access, NULL, anchor, TRUE, TRUE, pool));
> > + SVN_ERR (svn_io_check_path (path, &kind, pool));
> > + SVN_ERR (svn_wc_adm_open (&adm_access, NULL, anchor, TRUE,
> > + target && (kind != svn_node_none) ? FALSE : TRUE,
> > + pool));
> Why is it necessary to check the node kind of path? The original code
> didn't do that.

because it failed update_test#14 (update_deleted_missing_dir) without the
check. It seems in the case update would fail because it assumes other
directory under anchor is locked. so I just special-cased it to fallback the
original behavior - treelock the anchor.


To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Jul 13 13:47:02 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.