Re: [PATCH] mime-type detection "improvement"

kfogel@collab.net wrote:
> I haven't reviewed the patch (sorry, just lack of time), but have you
> seen these issues?

No, thank you for pointing me to them.

> http://subversion.tigris.org/issues/show_bug.cgi?id=1002

Seems unrelated, targets the problem that subversion uses the mime-type
of files to decide whether files are mergable (binary) or not, and in a
very crude manner indeed.

> http://subversion.tigris.org/issues/show_bug.cgi?id=1233

Seems (after some truble uudecoding mail attachment served as HTML :) to
do exactly what I'm trying to do

Major differences are:

+ 1233 has test (big "+" there)
- 1233 parses mime.types file for every time a type-guess is req'ed, I
do one parse into an apr_hash_t, and use that for lookup
- 1233 tries to work only on unix (it should work just fine on other
platforms, only the paths for mime.types should be different)

Points:

* 1233 is a "better" patch (to start with anyway)
* The hashing approach should be directly transferable to 1233 (and i
would be happy to do it, should 1233 be accepted into svn)
* Making 1233 work on all platforms only requires minor changes
* The list of files to parse mime.types from should probably be in a
svn_config variable, with a compiled default (possibly depending on the
platform)

Unfortunatly, I'm unable to track down the mail-address of the submitter
of the patch mentioned in issue 1233, or I would have CC'ed him. I'll
try to figure out how to refer to my email's from issuezilla and post
some links to my messages under issue 1233.

-- 
Helge
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org