Re: [PATCH] Better progress indicator for the 'svn' command-line client

Mukund <mukund@tessna.com> writes:

> On Wed, Jul 09, 2003 at 02:05:35PM +0100, Philip Martin wrote:
> | Since there is only one integer, the callback itself must have state
> | information to count the number of times it is called. Is this the
> | best way to do it? Perhaps the state should be in the calling
> | library, with two numbers being passed to the callback.
>
> The feature is quite a colourful bikeshed already :-)

I don't think API design is a bikeshed.

> I cannot find advantages or disadvantages of either approach.
> An argument would be that since all clients would need to have a counter
> to show a progress, why not implement this in the client library.
> A counter argument would be since all clients do not need to show
> progress they don't need a counter, and it needn't be maintained
> unnecessarily. Yet another colourful bikeshed.

Suppose my application makes several Subversion API calls in
succesion. Am I allowed to reuse the feedback baton? When should I
reset the state in the baton? How does the reset interact with the
the cancel func? Does your choice of API mean that I am unable to
reuse a baton? Is that a bikeshed?

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org