Re: [PATCH] Better progress indicator for the 'svn' command-line client

Ben Collins-Sussman <sussman@collab.net> writes:

> Mukund <mukund@tessna.com> writes:
>
>> * subversion/include/svn_wc.h
>> (svn_wc_notify_func_t): Add an extra parameter to pass the deltas count
>>
>> Index: subversion/include/svn_wc.h
>> ===================================================================
>> --- subversion/include/svn_wc.h (revision 6415)
>> +++ subversion/include/svn_wc.h (working copy)
>> @@ -333,7 +333,8 @@
>> const char *mime_type,
>> svn_wc_notify_state_t content_state,
>> svn_wc_notify_state_t prop_state,
>> - svn_revnum_t revision);
>> + svn_revnum_t revision,
>> + int txdeltas_count);
>
> You just added a new parameter to a public API.
>
> Were you planning to document it? :-)

Since there is only one integer, the callback itself must have state
information to count the number of times it is called. Is this the
best way to do it? Perhaps the state should be in the calling
library, with two numbers being passed to the callback.

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org