Re: [PATCH] Issue 1313 - svn copy URL1 URL2 fails silently

Ben Collins-Sussman <sussman@collab.net> writes:

> Philip Martin <philip@codematters.co.uk> writes:
>
>> My objection is more that three connections are being made while it
>> should be possible to get away with only one. There is no way that a
>> single session can handle cross repository copies, so attempts to do
>> it must already fail.
>
> That implies that each function in each RA layer must be in charge of
> noticing multiple UUIDs. Oof.

No, I don't think so.

> In this case, I'm not sure how it would even be possible. We open a
> session to a URL, then get a commit-editor from the RA layer, then
> tell it to copy one path to another. The RA layer never even gets a
> chance to *see* the second URL.

It just works if the URLs refer to the same repository, no need to
check UUIDs. However, if the URLs refer to separate repositories then
the the current code

   common_url = get_longest_ancestor (source_url, target_url)
   open_ra_session (common_url)

is going to generate common_url that does not refer to a repository,
that's going to cause an error, isn't it? If the error really must be
"improved", then perhaps the solution is to check paths in the
repository, rather than UUIDs.

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org