Re: [PATCH] Issue 1313 - svn copy URL1 URL2 fails silently

Ben Collins-Sussman <sussman@collab.net> writes:

> Philip Martin <philip@codematters.co.uk> writes:
>
>> This looks a wrong to me. At present an URL to URL copy uses a single
>> RA session because only copies within a repository are supported.
>> Your patch introduces the overhead of two additional RA sessions just
>> to handle an error case. For those cases where there is no error
>> (which is likely to be the common case) three RA sessions will be
>> opened onto the same repository.
>
> Well, I was thinking maybe his new block of code could just use a
> subpool to open the 2 sessions, then destroy the subpool.

My objection is more that three connections are being made while it
should be possible to get away with only one. There is no way that a
single session can handle cross repository copies, so attempts to do
it must already fail. Adding the overhead introduced by the patch to
copies that work, simply to get some sort of "neat" error message for
cases that already fail, just doesn't seem right to me.

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org