Re: [PATCH]: tools/client-side/bash_completion

On Mon, Jun 30, 2003 at 04:40:25PM -0400, Tim Moloney wrote:
> Greg Stein wrote:
> >On Mon, Jun 30, 2003 at 01:57:19PM -0500, David Summers wrote:
> >>So I tried the following patch to hopefully fix it. Does this look right?
> >>If so, let me know and I'll go ahead and commit it as soon as someone
> >>reviews and OKs it.
> >
> >Yup. I get the same error, and this fixes it right up.
> >
> >+1 to commit.
>
> I submitted the same patch about six months ago and was told that
> extglob needed to be enabled in bash for bash completion to work.
> I enabled extglob and bash completion did indeed start working.
> I don't know enough about extglob to know if it is really required.
> I just wanted to point this out in case the patch doesn't really
> fix the problem.

I agree. @${...} is entirely different from @(...), and will produce
incorrect results. For an example, in a shell with 'shopt -s extglob',
type 'svn ci --editor-cmd --' and then hit Tab before and after this
patch.

The need for 'shopt -s extglob' is explained in the comment at the top
of the completion file.

-- 
Colin Watson                                  [cjwatson@flatline.org.uk]
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org