Re: svn commit: rev 6376 - trunk/tools/client-side

david@tigris.org writes:

> Author: david
> Date: Mon Jun 30 15:05:56 2003
> New Revision: 6376
>
> Modified:
> trunk/tools/client-side/bash_completion
> Log:
> * tools/client-side/bash_completion : Fix syntax errors in bash_completion
> script.

It may "fix" the syntax errors but it doesn't work. The original code
is OK. I suspect you don't have extended pattern matching enabled,
see the comment at the head of the file for details.

> Reviewed and approved by gstein.
>
> Modified: trunk/tools/client-side/bash_completion
> ==============================================================================
> --- trunk/tools/client-side/bash_completion (original)
> +++ trunk/tools/client-side/bash_completion Mon Jun 30 15:05:56 2003
> @@ -45,7 +45,7 @@
> # if not typing an option, or if the previous option required a
> # parameter, then fallback on ordinary filename expansion
> if [[ "$cur" != -* ]] || \
> - [[ ${COMP_WORDS[COMP_CWORD-1]} == @($optsParam) ]] ; then
> + [[ ${COMP_WORDS[COMP_CWORD-1]} == @${optsParam} ]] ; then

This doesn't work.

> return 0
> fi
>
> @@ -181,7 +181,7 @@
> esac
>
> # skip next option if this one requires a parameter
> - if [[ $opt == @($optsParam) ]] ; then
> + if [[ $opt == @${optsParam} ]] ; then

ditto.

> ((++i))
> fi
> done

Please revert this commit. If you want to get rid of the requirement
for extended pattern matching then please replace it with some code
that works.

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org