Re: [PATCH] help setting up Visual Diff

On Sun, Jun 29, 2003 at 01:28:10AM -0700, Robert Spier wrote:
>...
> +++ subversion/libsvn_subr/io.c (working copy)
> @@ -1154,14 +1154,7 @@
>
> if (user_args != NULL)
> nargs += num_user_args;
> - else
> - nargs += 1; /* -u */
>
> - if (label1 != NULL)
> - nargs += 2; /* the -L and the label itself */
> - if (label2 != NULL)
> - nargs += 2; /* the -L and the label itself */

I don't think that you want to remove the label options. Those given
human-readable information about what is being diff'd. Without them, you
could end up with some *very* unintuitive file names.

The -u should go, tho.

Note: if the diff-cmd can't accept -L, then an intermediate script should
be used to remove them.

> Patch Two:

Oof... please use two emails. I had no idea there was a second patch in
here. I went to delete the bottom of the email from my response, and *then*
I saw a different patch was present.

FWIW, the second one looks good.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org