Re: cvs2svn.py fails converting repository with the attached file

On Thu, Jun 26, 2003 at 06:42:30PM -0500, kfogel@collab.net wrote:
> MBK writes:
> > > rcsparse isn't technically part of svn, so I haven't committed
> > > this change. :-(

I'm not sure we should. The provided file is corrupt, per the RCS file
specification. Type 'man rcsfile' and look at the spec for the author. Or,
you can read this:

    http://subversion.tigris.org/servlets/ReadMsg?list=dev&msgNo=29647

If we want to be "nice" and go ahead parse the file, then I'd like to see a
very clear comment in rcsparse.py about *why* we're allowing for invalid
files.

And note that we would still have problems round 'co' and its warning about
the invalid file.

> David Summers <david@summersoft.fay.ar.us> writes:
> > The patch certainly fixes the abnormal termination of the script, but now
> > I'm getting: [errors from rcs 'co']

Yup. The file is invalid :-)

>...
> So the best solution would be to commit this change upstream. I'll
> take a look at the patch & talk to Greg Stein about getting it into
> the master rcsparse tree.

See above.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org