kfogel@collab.net writes:
> cmpilato@collab.net writes:
> > > Greg Hudson noticed a documentation bug:
> > >
> > > * subversion/include/svn_path.h: Note that paths are non-null unless
> > > otherwise documented.
> > > (svn_path_uri_encode, svn_path_uri_encode): Say that these return
> > > null when incoming path is null.
> >
> > Honestly, I think the right solution is to stop allowing NULL input
> > here. We expect better than that for the rest of the svn_path.h
> > functions, so perhaps we should file a bite-sized task for disallowing
> > NULL input to these functions (and fixing calling code to ensure that
> > that won't happen). Thoughts?
>
> Sure -- though that's the solution to a different bug :-).
>
> (We don't know if it's really bite-sized or not, I guess. The
> conditions in the callers could be arbitrarily complex...)
Sure we do. The conditions are quite simple, really. Calls like
this:
new_path = svn_path_uri_encode (path, pool)
become:
new_path = path ? svn_path_uri_encode (path, pool) : NULL;
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Jun 23 22:30:35 2003