D.J. Heap wrote:
> Revised refactoring patch with _item class changed to ProjectItem.
>
> Log:
>
> Refactor code common to dsp and vcproj generator into gen_win.py.
>
> * build/generator/gen_vcnet_vcproj.py
> * build/generator/gen_msvc_dsp.py
> (write_project): refactor configs and sources generation into
> calls to gen_win.py
> (write): refactor install_targets generation into call to
> gen_win.py and use it's new ProjectItem class
> (class _item): moved to gen_win.py as ProjectItem
>
> * build/generator/gen_win.py
> (get_install_targets): refactored method
> (get_configs): refactored method
> (get_proj_sources): refactored method
> (class ProjectItem): refactored class
[snip]
>@@ -201,10 +155,10 @@
>
> deplist = [ ]
> for i in range(len(depends)):
>- deplist.append(_item(guid=guids[depends[i].name],
>+ deplist.append(gen_win.ProjectItem(guid=guids[depends[i].name],
> index=i,
> ))
>- targets.append(_item(name=target.name,
>+ targets.append(gen_win.ProjectItem(name=target.name,
> path=string.replace(fname, os.sep, '\\'),
> guid=guids[target.name],
> depends=deplist,
>
[snip]
>@@ -164,7 +118,7 @@
> for dep in depends:
> dep_names.append(dep.proj_name)
>
>- targets.append(_item(name=target.proj_name,
>+ targets.append(gen_win.ProjectItem(name=target.proj_name,
> dsp=string.replace(fname, os.sep, '\\'),
> depends=dep_names))
>
Except for parameter indentation in these two bits, the patch seems O.K.
to me.
--
Brane Čibej <brane_at_xbc.nu> http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Jun 23 21:35:11 2003