[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: issue 919 solution

From: Greg Hudson <ghudson_at_MIT.EDU>
Date: 2003-06-23 19:23:36 CEST

On Thu, 2003-06-19 at 19:42, Branko ╚ibej wrote:
> Even better, instead of marking the directory incomplete, the right
> solution would be to set the entry's revision correctly -- in this case,
> the "correct" revision would be SVN_INVALID_REVNUM, since the thing
> doesn't exist.

I wonder if it wouldn't be better to use the actual revision where the
file doesn't exist. If I "svn up -r0 filename", then that revision is 0
(but it might be something else, of course); if I svn rm a file and
commit that, then it's the newly committed revision. Of course, we
would also need an entry flag for "this entry doesn't exist as of this
rev", so that the code knows not to expect a base text. But when we're
reporting to the server, we don't have to check this flag and call
delete_entry(); instead, we just pass in the revision where the file
doesn't exist.

I can't immediately think of any case where it's important to remember
which deleted revision we're at, but it feels better to me to preserve
this information.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Jun 23 19:24:34 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.