[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 6318 - trunk/subversion/libsvn_delta

From: Philip Martin <philip_at_codematters.co.uk>
Date: 2003-06-23 01:17:22 CEST

cmpilato@collab.net writes:

> Thanks for the find-n-fix, Philip. I'm still confused as to what made
> this bug appear, but I'm content to know it's been killed.

The editor driver was opening the same directory twice in succession,
I didn't track the bug all the way through the RA layers as the driver
was obviously doing the wrong thing.

I don't really know the ra_dav editor code that well, but looking at
it now see how commit_open_dir in libsvn_ra_dav/commit.c only uses the
last component of the input path, the rest comes from the "known"
parent. This meant that the ra_dav editor would construct an invalid
path. Perhaps this function should do a sanity check on the whole
path? Or perhaps the editor interface should change and only pass the
last component?

Philip Martin
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Jun 23 01:18:19 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.