Re: [PATCH] Windows vcproj generator

D.J. Heap wrote:

> I wasn't sure if the _item class that moved to gen_win.py should be
> renamed or not, so I just left it.

The Python convention is that names starting with a single underscore
are considered private to the module (although it's not enforeced by the
name lookup rules, as you noticed). So in this case it should be
renamed, yes. If the name reflected a bit more about what kind of item
it is, that would be even better.

-- 
Brane Čibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org