On Thursday 19 June 2003 13:43, cmpilato@collab.net wrote:
> Christian Daudt <csd_ob@daudt.org> writes:
> > So someone else doesn't spend a morning trying to figure why they're
> > getting coredumps all of the sudden...
>
> Do I detect (in your patch) a note of sarcasm? :-)
>
Only a bit ;-) Seriously, you can generate a core dump and still tell people
that aren't familiar with the code that you meant to do just that
(printf/abort maybe). I understand that the intent is to catch errors there
but if you want to extract more useful cycles from people that are more
marginally involved in the development process (i.e. me) it's not a bad idea
to give hints someone debugging an error that they are barking up the wrong
tree.
> Dude, I'm sorry you wasted time looking at the wrong thing. But the
> clues are present. In the very libsvn_ra_dav code you pasted, there
> is a comment indicating that that section of code expects to get that
> name= attribute.
Unfortunately I have a very deep distrust of comments in code from chasing red
herrings because of out-of-date comments one too many times (I know that goes
against the last patch I sent - ok I admit it. It was a sarcastic one ;-).
> Now, I dunno why you're seeing a case where this
> attribute isn't present, but if I could be so daring as to risk
> annoying you -- would you mind trying to solved *that* problem? I
> mean, if you have a Subversion server that's sending your client a
> bogus REPORT response, by golly we want to know about it.
I have zero knowledge of the svn code right now (from your comments I take it
the server is misbehaving, I didn't even know if the client or the server was
the one at fault up to know). And I haven't seen it firsthand, it's just been
reported to me by a couple of users (who of course haven't seen it since). I
was hoping for someone to look at my email and say "ah-ha ! I know what's
going on". Guess that isn't going to happen :-( I'll try to set up some
debugging on the server to try to keep tabs on what's going on. If anyone
wants more info (or the coredump) let me know. I'll also file a bug report on
this one.
> Please help us, and please don't be offended if your alternative patch
> falls by the wayside. (Our entire svn_string.c function set does not
> try to protect against NULL input, not just that one function).
I'll try (to help, not to be offended ;-)
cheers,
csd
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Jun 19 23:36:09 2003